Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitjacker: init at 0.0.2 #107618

Merged
merged 1 commit into from Jan 21, 2021
Merged

gitjacker: init at 0.0.2 #107618

merged 1 commit into from Jan 21, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 26, 2020 •
edited

Motivation for this change

Gitjacker downloads git repositories and extracts their contents
from sites where the .git directory has been mistakenly uploaded.
It will still manage to recover a significant portion of a repository
even where directory listings are disabled.

https://github.com/liamg/gitjacker

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 4, 2021 11:52
@fabaff
Copy link
Member Author

fabaff commented Jan 6, 2021

@GrahamcOfBorg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107618 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • gitjacker

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107618 run on x86_64-linux 1

1 package marked as broken and skipped:
  • gitjacker

@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2021

Result of nixpkgs-review pr 107618 run on x86_64-linux 1

1 package marked as broken and skipped:
  • gitjacker

@SuperSandro2000
Copy link
Member

I don't understand why it is marked as broken.

@SuperSandro2000 SuperSandro2000 merged commit ae6fb64 into NixOS:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @roberth