vtk: clean up / reduce code repetition #107617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the vtk expressions to use a generic base expression, which is used for all 3 versions. vtk 7.x no longer uses gcc 8, since the quirk of it not building with gcc 9 seems to have been fixed. This also makes the python bindings available for all 3 versions, and fixes building them for vtk 8 by adding a patch.
FRidh
reviewed
Dec 26, 2020
|
@ofborg build vtk_7 vtk_8 vtk_9 python2Packages.vtk_7 python2Packages.vtk_8 python2Packages.vtk_9 python3Packages.vtk_7 python3Packages.vtk_8 python3Packages.vtk_9 |
prusnak
requested changes
Dec 26, 2020
|
@prusnak only that that's no change from before (which in turn might be because vtk 8 didn't build with python 3 prior to this PR). I do want to clean that up and see if I can update all the dependents to vtk 9 once this is merged. |
|
Thanks for the cleanup and marking myself as maintainer on the remaining versions. |
|
@lheckemann good idea. Thanks for the modifications! |
prusnak
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This refactors the vtk expressions to use a generic base expression,
which is used for all 3 versions.
vtk 7.x no longer uses gcc 8, since the quirk of it not building with
gcc 9 seems to have been fixed.
This also makes the python bindings available for all 3 versions, and
fixes building them for vtk 8 by adding a patch.
cc @tfmoraes @knedlsepp I've listed you as maintainers for all 3 versions, hope that's alright — if not we can of course change that back. I've also added myself.
Things done