Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apacheHttpd, nixos/httpd: set lua paths #107649

Merged
merged 2 commits into from Dec 26, 2020
Merged

apacheHttpd, nixos/httpd: set lua paths #107649

merged 2 commits into from Dec 26, 2020

Conversation

nagy
Copy link
Member

@nagy nagy commented Dec 26, 2020

Motivation for this change

Without this, lua script handlers do not find the packages that are provided with the lua package.
Note that, since the luaSupport argument of the apacheHttpd derivation defaults to false, this wont change the generated config file unless the derivation is built with lua support enabled.

More information on the used apache directives is here:
https://httpd.apache.org/docs/trunk/mod/mod_lua.html#luapackagepath
https://httpd.apache.org/docs/trunk/mod/mod_lua.html#luapackagecpath

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nagy
apacheHttpd: passthru lua variables
f20d809
@nagy
nixos/httpd: set lua paths
f2ca4c8 
We conditionally set the lua paths for the Apache mod_lua module. This
allows executing Lua script handlers to require modules, that have been
packaged with the supplied Lua derivation of Apache.

For more information, see:

  https://httpd.apache.org/docs/2.4/mod/mod_lua.html#luapackagecpath
  https://httpd.apache.org/docs/2.4/mod/mod_lua.html#luapackagepath
@nagy
Copy link
Member Author

nagy commented Dec 26, 2020

@lovek323 @peti , since you are the maintainers, could you review this please ?

@peti peti merged commit 676b7d5 into NixOS:master Dec 26, 2020
@nagy nagy deleted the apache-lua-paths branch December 26, 2020 18:05
@nagy nagy mentioned this pull request Jan 5, 2021
Merged
10 tasks
aanderse
aanderse reviewed Jan 17, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the fact, but I would like this amended if you don't mind please.

nixos/modules/services/web-servers/apache-httpd/default.nix Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagy @aanderse @peti