Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentabletdriver: init at 0.4.2/add module #107638

Merged
merged 2 commits into from Dec 30, 2020
Merged

opentabletdriver: init at 0.4.2/add module #107638

merged 2 commits into from Dec 30, 2020

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Dec 26, 2020 •
edited

Motivation for this change

https://github.com/InfinityGhost/OpenTabletDriver

OpenTabletDriver is an open source, cross platform, user mode tablet driver. The goal of OpenTabletDriver is to be cross platform as possible with the highest compatibility in an easily configurable graphical user interface.

It supports multiple tablets that are badly supported in Linux. Even for tablets already supported by other means (i.e.: libinput or xf86-input-wacom), OpenTabletDriver offers a graphical interface, plugins and more customization.

List of supported tablets: https://github.com/InfinityGhost/OpenTabletDriver/projects/4

Closes #107544.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada thiagokokada changed the title opentabletdriver: Init at 0.4.2 opentabletdriver: init at 0.4.2 Dec 26, 2020
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 107638 1

1 package built:
  • opentabletdriver

@thiagokokada thiagokokada mentioned this pull request Dec 26, 2020
Closed
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Dec 27, 2020 •
edited

This package works (finally) but it needs some preparation for it to actually work:

  • Blacklist hid-ulogic module
  • Start OpenTabletDriver.Daemon, can be done as a systemd user service
  • Needs to add the udev rules by using service.udev.packages = [ opentabletdriver.udev ];
  • I am not sure about this one needs to use libinput by setting services.x11.libinput.enable = true; (or at least make libinput as the default driver for tablets)

Except for the last one (that I think it is too invasive) I think I can set a module, something like hardware.opentabletdriver.enable that could do the first 3 parts for you. I just don't know if I should create in this PR or in another PR. WDYT 🤔 ?

@thiagokokada thiagokokada marked this pull request as ready for review December 27, 2020 04:26
@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Dec 27, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 27, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@thiagokokada
Copy link
Contributor Author

Fixed libudev -> udev (didn't know it was not available in all-packages).

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Dec 27, 2020 •
edited

So I went ahead and added a module too, solving the issues from this comment: #107638 (comment)

@thiagokokada thiagokokada changed the title opentabletdriver: init at 0.4.2 opentabletdriver: init at 0.4.2/add module Dec 27, 2020
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 107638 1

1 package built:
  • opentabletdriver

@marvin-mk2 marvin-mk2 bot requested a review from kevincox December 28, 2020 19:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/415

@thiagokokada
Copy link
Contributor Author

@InfinityGhost Fixed the issues. Can I ask for a re-review?

If approved, can you run /status needs_merger too?

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 29, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

InfinityGhost
InfinityGhost approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@InfinityGhost InfinityGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/status needs_merger

@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 can you review/merge?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/311

kevincox
kevincox reviewed Dec 30, 2020
View reviewed changes
nixos/modules/hardware/opentabletdriver.nix Outdated
type = types.bool;
description = ''
Enable OpenTabletDriver udev rules and blacklist kernel modules known
to conflict with OpenTabletDriver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also starts the service. Maybe just say "enable"? Although the blacklist warning does seem interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevincox Fixed description, WDYT?

@kevincox kevincox merged commit 58f3c19 into NixOS:master Dec 30, 2020
@thiagokokada thiagokokada deleted the opentabletdriver-init branch December 30, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox left review comments

@ericdallo ericdallo ericdallo approved these changes

@InfinityGhost InfinityGhost InfinityGhost approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Request: InfinityGhost/OpenTabletDriver
5 participants
@thiagokokada @nixos-discourse @kevincox @ericdallo @InfinityGhost