Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmolcas: fix fallout from #83888 #107636

Merged
merged 2 commits into from Dec 26, 2020
Merged

openmolcas: fix fallout from #83888 #107636

merged 2 commits into from Dec 26, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Removed non-functional lines.
Openmolcas does not build with the blas/lapack switching mechanism

CC @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
openmolcas: fix fallout from NixOS#83888
c3fadb9 
Removed non-functional lines.
Openmolcas does not build with the blas/lapack switching mechanism
@markuskowa
openmolcas: set platform to x86-64-linux
1ba79ed 
This is the main development platforms. Others are not
officially supported.
@markuskowa markuskowa merged commit 7543a5b into NixOS:master Dec 26, 2020
@markuskowa markuskowa deleted the clean-molcas branch December 26, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @SuperSandro2000