Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"manager" URLs not blocked for content that doesn't belong to you #51

Open
TrueBrain opened this issue Dec 26, 2020 · 1 comment
Open

"manager" URLs not blocked for content that doesn't belong to you #51

TrueBrain opened this issue Dec 26, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TrueBrain
Copy link
Member

If after login I for example visit:

https://bananas.staging.openttd.org/manager/newgrf/66724456

It acts like I can edit this package, while I really cannot. When I press save, the API will block the request and not processed it, but it does look weird from a user perspective.

Guess we should check for permissions when visiting those pages, and show an error instead of an edit page.
@TrueBrain TrueBrain added bug Something isn't working good first issue Good for newcomers labels Dec 26, 2020
@James103
Copy link
Contributor

James103 commented Jul 3, 2021

I can reproduce this as of the time of writing (1. log in, 2. follow the link above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @James103