Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mindustry: 121.4 -> 122 #107646

Merged
1 commit merged into from Dec 28, 2020
Merged

mindustry: 121.4 -> 122 #107646

1 commit merged into from Dec 28, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Dec 26, 2020 •
edited

It looks like arm needs libarcarm64.so too... but I have no idea what package provides it and the web isn't helpful

edit: duuh... libARCarm... it has something to do with Anuke's Arc

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107646 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • mindustry
  • mindustry-server

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107646 run on x86_64-linux 1

2 packages built:
  • mindustry
  • mindustry-server

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@fgaz fgaz mentioned this pull request Dec 27, 2020
Closed
@ghost
Copy link

ghost commented Dec 28, 2020

Builds and starts fine on x86_64-linux. Did this work on aarch64 before?

@fgaz
Copy link
Member Author

fgaz commented Dec 28, 2020

@petabyteboy Not sure if it worked (probably not, seeing how arc fails at runtime) but at least it did build. I marked it as broken for now.

@SuperSandro2000 updated the license

@ghost ghost merged commit 6792a17 into NixOS:master Dec 28, 2020
@fgaz fgaz deleted the mindustry/122 branch December 28, 2020 16:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000