Implement GitHub logins #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingiun
force-pushed
the
github-login
branch
from
5220eb3
to
7960e96
Compare
Requires the following configuration options enable_github_login = 1 github_client_id github_client_secret Or github_client_secret_file which points to a file with the secret
pingiun
force-pushed
the
github-login
branch
from
7960e96
to
bbd4891
Compare
edolstra
reviewed
Jan 4, 2021
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Instead the github_client_id option is used to detect if github logins should be enabled.
|
Thanks! |
|
I've enabled this on hydra.nixos.org, so GitHub logins are now possible! The only caveat is that you can't login using GitHub if the GitHub email address is equal to an already existing Google login. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the following configuration options
github_client_idgithub_client_secretorgithub_client_secret_file