Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pre-commit-hooks: init at 3.3.0 #106918

Merged
merged 1 commit into from Dec 16, 2020
Merged

python3Packages.pre-commit-hooks: init at 3.3.0 #106918

merged 1 commit into from Dec 16, 2020

Conversation

kalbasit
Copy link
Member

Motivation for this change

In order to use the pre-commit-hooks with http://github.com/cachix/pre-commit-hooks.nix, we need to be able to define an entry point that is accessible locally. This pull requests adds the pre-commit-hooks repository as its own Python module so we can access it and run its hooks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit mentioned this pull request Dec 14, 2020
Closed
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build python3Packages.pre-commit-hooks

jonringer
jonringer approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/106918

3 packages built:
python37Packages.pre-commit-hooks python38Packages.pre-commit-hooks python39Packages.pre-commit-hooks

@jonringer jonringer merged commit 30c312d into NixOS:master Dec 16, 2020
@kalbasit kalbasit deleted the opensource/nixpkgs/add-pre-commit-hooks branch December 16, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @jonringer