Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echidna: init at 1.7.2 #106919

Merged
merged 1 commit into from Aug 5, 2021
Merged

echidna: init at 1.7.2 #106919

merged 1 commit into from Aug 5, 2021

Conversation

arcz
Copy link
Member

@arcz arcz commented Dec 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcz arcz force-pushed the echidna branch 3 times, most recently from d3e860a to 7ecf565 Compare December 14, 2020 23:33
@samb96
Copy link
Contributor

samb96 commented Dec 15, 2020

@GrahamcOfBorg eval

rmcgibbo
rmcgibbo suggested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 106919 at 7ecf5656 run on x86_64-linux 1

1 package failed to build (new failures):
  • echidna

build failure: https://gist.github.com/rmcgibbo/8c138763bfa8b9555c93d953bebd1a14

pkgs/tools/security/echidna/default.nix Outdated Show resolved Hide resolved
@arcz arcz changed the title echidna: init at 1.6.0 echidna: init at 1.7.2 Jul 27, 2021
@arcz
Copy link
Member Author

arcz commented Jul 27, 2021

@rmcgibbo @SuperSandro2000 I updated this PR, can you please take a look?

@rmcgibbo rmcgibbo requested review from rmcgibbo and removed request for rmcgibbo July 27, 2021 15:23
@rmcgibbo
Copy link
Contributor

I don't see any problems, but I'm not familiar with the nixpkgs haskell ecosystem at all.

@SuperSandro2000 SuperSandro2000 merged commit ae07a5a into NixOS:master Aug 5, 2021
@arcz arcz deleted the echidna branch August 5, 2021 12:44
@vbgl
Copy link
Contributor

vbgl commented Oct 13, 2021

FWIW, the echidna package was broken by 06274cd (part of #134317).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo Awaiting requested review from rmcgibbo

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arcz @samb96 @rmcgibbo @vbgl @SuperSandro2000