Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citra: 2020-03-21 -> 2020-12-07 #106915

Merged
merged 1 commit into from Jan 18, 2021
Merged

citra: 2020-03-21 -> 2020-12-07 #106915

merged 1 commit into from Jan 18, 2021

Conversation

Sebelino
Copy link
Contributor

Motivation for this change

Version bump, comes with support for save states and other improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Sebelino
citra: 2020-03-21 -> 2020-12-07
f35820f 
Version bump, comes with support for save states and other improvements.
@ofborg ofborg bot requested a review from abbradar December 14, 2020 17:44
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 106915 run on x86_64-linux 1

1 package built:
  • citra

Working fine for me and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/316

@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 106915 1

1 package built:
  • citra

Small issue: Help -> About Citra reports GIT-NOT-FOUND as version.

It would be interesting to fix it, but can be done in another PR.

@SuperSandro2000 SuperSandro2000 merged commit 5008e47 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@WolfangAukang WolfangAukang WolfangAukang approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sebelino @WolfangAukang @nixos-discourse @thiagokokada @SuperSandro2000 @Janik-Haag