Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docopts: init at 0.6.3-rc2 #106917

Merged
merged 3 commits into from Dec 22, 2020
Merged

docopts: init at 0.6.3-rc2 #106917

merged 3 commits into from Dec 22, 2020

Conversation

con-f-use
Copy link
Contributor

@con-f-use con-f-use commented Dec 14, 2020 •
edited

Motivation for this change

Docopts, mind the trailing "s", is the shell scripting tool for the well known docopt python library. Written in go.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@con-f-use
Copy link
Contributor Author

con-f-use commented Dec 19, 2020 •
edited

@SuperSandro2000 @AndersonTorres @zimbatm
Can one of you gents please review/merge this, when you have the time? Sorry to bother you, you're just the first people that I could think of.

@AndersonTorres
Copy link
Member

Looks cute to me.

@SuperSandro2000
Copy link
Member

@ofborg build

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Also you forgot to add this to all packages.

@con-f-use
Copy link
Contributor Author

con-f-use commented Dec 21, 2020 •
edited

Stupid me, sorry. Good catch! Thanks a bunch for being this vigilant!

@AndersonTorres
Copy link
Member

@con-f-use it is bugged. Read ofborg's log.

@con-f-use
Copy link
Contributor Author

con-f-use commented Dec 21, 2020 •
edited

@AndersonTorres, do you mean the following log:

nix-env failed:
warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/.gc-of-borg-outpaths.nix:44:12, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/top-level/release-lib.nix:121:6, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/lib/attrsets.nix:292:43:
while evaluating 'hydraJob' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/lib/customisation.nix:171:14, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/top-level/release-lib.nix:121:14:
while evaluating the attribute 'drvPath' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/lib/customisation.nix:188:13:
while evaluating the attribute 'drvPath' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/lib/customisation.nix:155:13:
while evaluating the attribute 'buildInputs' of the derivation 'cutelyst-2.13.0' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/stdenv/generic/make-derivation.nix:192:11:
while evaluating the attribute 'UWSGICONFIG_PHP_LDFLAGS' of the derivation 'uwsgi-2.0.19.1' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/stdenv/generic/make-derivation.nix:192:11:
attempt to call something which is not a function but a string, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/servers/uwsgi/default.nix:97:29

No mention of anything docopts. That seems like a webserv dependency problem that ofborg has with micro wsgi, rather than something in my package or its dependencies, but admittedly, I don't understand what's going on here. Also, mine is not the only recent PR with this exact message.

@SuperSandro2000
Copy link
Member

@ofborg eval

@AndersonTorres
Copy link
Member

All OK?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106917 run on x86_64-linux 1

1 package built:
  • docopts

@SuperSandro2000
Copy link
Member

All OK?

I think so. I am just taking it slowly.

@SuperSandro2000 SuperSandro2000 merged commit 39fe2fc into NixOS:master Dec 22, 2020
@con-f-use
Copy link
Contributor Author

I think so. I am just taking it slowly.

And still too fast for me. I would have squashed the commit history after a final "okay". Not that important. Thanks for your hard work again!

@con-f-use con-f-use deleted the gocli_docopts branch December 30, 2020 21:45
@kirillrdy kirillrdy mentioned this pull request Feb 9, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@con-f-use @AndersonTorres @SuperSandro2000