Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-ident: change PATH #106910

Merged
merged 1 commit into from Jan 18, 2021
Merged

ssh-ident: change PATH #106910

merged 1 commit into from Jan 18, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

The wrapper is not working anymore, so the ssh-agent is no more shared,
as the script removes the environment PATH variable, I pinned the
ssh-agent binary and removed the wrapper.

Also, as this script doesn't require a compiler, I switched from stdenv
to stdenvNoCC.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from telotortium December 14, 2020 16:43
@SuperSandro2000
Copy link
Member

@freezeboy please resolve the merge conflict.

@freezeboy
ssh-ident: change PATH
3cac3df 
The wrapper is not working anymore, so the ssh-agent is no more shared,
as the script removes the environment PATH variable, I pinned the
ssh-agent binary and removed the wrapper.

Also, as this script doesn't require a compiler, I switched from stdenv
to stdenvNoCC.
@freezeboy
Copy link
Contributor Author

@SuperSandro2000 done

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106910 run on x86_64-linux 1

1 package built:
  • ssh-ident

@SuperSandro2000 SuperSandro2000 merged commit 6dfa72b into NixOS:master Jan 18, 2021
@freezeboy freezeboy deleted the change-ssh-ident branch January 19, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telotortium telotortium Awaiting requested review from telotortium

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @SuperSandro2000