Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.cc-wrapper: disable static compilation macOS #106925

Merged
merged 1 commit into from Dec 15, 2020
Merged

tests.cc-wrapper: disable static compilation macOS #106925

merged 1 commit into from Dec 15, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 14, 2020

macOS does not support this

Motivation for this change

Follow up to: #106908 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 14, 2020
@Mic92
Copy link
Member Author

Mic92 commented Dec 14, 2020

Should be safe to merge after eval.
cc @LnL7

@Mic92 Mic92 merged commit 2076311 into NixOS:staging Dec 15, 2020
@Mic92 Mic92 deleted the fix-darwin branch December 15, 2020 03:28
@Ericson2314 Ericson2314 mentioned this pull request Dec 21, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @matthewbauer