Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv/platform-notes: convert to markdown #106921

Merged
merged 1 commit into from Feb 21, 2021
Merged

stdenv/platform-notes: convert to markdown #106921

merged 1 commit into from Feb 21, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Dec 14, 2020 •
edited

Motivation for this change

Part of RFC 72.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/happy-docsgiving/10214/24

@ryantm ryantm added this to In progress in Conversion to CommonMark Docs via automation Dec 24, 2020
@ryantm ryantm moved this from In progress to Needs review in Conversion to CommonMark Docs Dec 24, 2020
@siraben siraben force-pushed the platform-notes-md branch 2 times, most recently from afc0b34 to 4126ce2 Compare January 3, 2021 11:43
@siraben siraben requested a review from ryantm January 5, 2021 05:18
jtojnar
jtojnar approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the conflict and fixed some of the issues. The output diff and rendered HTML look fine now.

@jtojnar jtojnar moved this from Needs review to Done (add to next Discourse update) in Conversion to CommonMark Docs Feb 21, 2021
@jtojnar jtojnar merged commit f876a5d into NixOS:master Feb 21, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Feb 21, 2021

Thanks.

@siraben siraben deleted the platform-notes-md branch February 21, 2021 06:34
@ryantm ryantm moved this from Done (add to next Discourse update) to Done (mentioned on Discourse) in Conversion to CommonMark Docs Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Conversion to CommonMark Docs
Done (mentioned on Discourse)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @nixos-discourse @jtojnar @SuperSandro2000