Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio-experimental, factorio-headless-experimental: 1.1.5 -> 1.1.6 #106924

Closed
wants to merge 1 commit into from
Closed

factorio-experimental, factorio-headless-experimental: 1.1.5 -> 1.1.6 #106924

wants to merge 1 commit into from

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Dec 14, 2020

Motivation for this change

https://forums.factorio.com/93072

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@priegger
Copy link
Contributor

Tested on x86_64 NixOS, both headless (as NixOS service) and the desktop version. I was able to connect to the server and play a little, so it seems to be fine. Thanks!

priegger
priegger approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@priegger priegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this for ~10 days. Works fine, thanks for the PR!

@lukegb
Copy link
Contributor Author

lukegb commented Jan 7, 2021

/marvin opt-in
/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 7, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 7, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 7, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@lukegb lukegb added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2021
@lukegb
Copy link
Contributor Author

lukegb commented Jan 7, 2021

Factorio 1.1.7 is out now. Abandoning this.

@lukegb lukegb closed this Jan 7, 2021
@lukegb lukegb deleted the factorio116 branch January 7, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priegger priegger priegger approved these changes

@nyanotech nyanotech nyanotech approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @priegger @nyanotech