Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeApplications: split derivation name into pname and version attributes #106923

Merged
merged 1 commit into from Dec 15, 2020
Merged

kdeApplications: split derivation name into pname and version attributes #106923

merged 1 commit into from Dec 15, 2020

Conversation

notpeelz
Copy link

@notpeelz notpeelz commented Dec 14, 2020 •
edited

Motivation for this change

It's currently impossible to write overlays that depend on either the package name or version since that information is lost when passed directly through the name attribute in mkDerivation.

I wasn't quite sure whether to target staging or master since this patch causes all kdeApplications derivations to reevaluate (around 155 derivations according to my nix repl).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@louistakepillz
kdeApplications: split drv name into pname and version attributes
d074587 
This change aims to make it easier to access the package name and
version individually when writing overlays for KDE derivations.
@ttuegel
Copy link
Member

ttuegel commented Dec 15, 2020

You were right to point this at staging. Thanks for taking care of this!

@ttuegel ttuegel merged commit f3e8cb1 into NixOS:staging Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notpeelz @ttuegel @louistakepillz