Result of nixpkgs-review pr 106906 run on x86_64-linux 1

thanks!

Hey, hey! Thanks for this change, but this PR broke rebuild on my system, because the niv binary is not in the resulting package. I use niv in a script which checks the existence of binaries at nixos-rebuild time.

/nix/store/c3p0a7k0pj34d8swq5k1ghm7lasylfmf-niv-0.2.18/bin: getDirectoryContents:openDirStream: does not exist (No such file or directory)

The issue is that you dropped the .bin. The changed line should probably to be:

niv = lib.getBin (haskell.lib.justStaticExecutables haskellPackages.niv);

I just realize this PR was open for 20 minutes without any hint of a second opinion. The change was pretty trivial, but it introduced a typo. I’ll take this as a reminder that more eyes are better, even for changes which one is confident about.

Ah, yes indeed. Looks like adding .bin or getBin doesn't help much. Someone will need to figure out what's happening in haskell.lib.justStaticExecutables, maybe it's interfering with enableSeparateBinOutput. Won't have time to investigate until next week, for now I'll revert: #107091

CC @zimbatm

Indeed, I have been too hasty :/ Here is a proper fix for my fix: #107096