Codechange: Rework 'start_date' parameter for AIs as a game setting #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
67cd896
to
468fd53
Compare
|
|
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
9d57162
to
22d6dfb
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
22d6dfb
to
de0acbb
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
2 times, most recently
from
c2fb0c3
to
2098bb4
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
2098bb4
to
dc4160e
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
dc4160e
to
8a73717
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
8a73717
to
dafa424
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
dafa424
to
3758474
Compare
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
3758474
to
b2948f3
Compare
- Moves 'start_date' AI parameter away from scripts losing its "per-AI" customization, into a game setting. It is now a "one or all" approach for the feature. - Retains the random deviation behaviour for nonzero values. This attempts to redo the whole start_date thing to be more sane, understandable and predictable.
…faults on 'settings_profile' - Now also displays Start Delay on AI/Game Script Config window - Allow the ability to enter values for both Max no. companies and Start Delay when clicking on their names inside the AI/Game Script Config window. - Start Delay defaults are based on the value of Settings Profile. - The means of handling default values of settings has thus been altered.
- STR_AI_SETTINGS_START_DELAY no longer in use.
SamuXarick
force-pushed
the
rework-start_date-as-game-setting
branch
from
b2948f3
to
7265fcc
Compare
|
There has been so much talk about this .. and honestly, I am tired. Sorry, I am going to close this one. Not because it is a bad idea as such, but because the effort required for us to review this, based on the history. I can leave it open and act someone might look at it some day, but really, nobody will. Sorry about that. Please start with smaller well documented more clear described and tested PRs first, and build up from there. That helps us and you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to redo the whole start_date thing to be more sane, understandable and predictable.