Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitaly: add patch to support libgit2 1.1.0 #106909

Closed
wants to merge 1 commit into from
Closed

gitaly: add patch to support libgit2 1.1.0 #106909

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2020

libgit2 was updated in eb7aa55.
Upstream still uses v30 of git2go, the go bindings for libgit2 1.0.x. There is
an open issue regarding libgit2 1.1.0 support here:
https://gitlab.com/gitlab-org/gitaly/-/issues/3330
Until this is solved we include a patch.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gitaly: add patch to support libgit2 1.1.0
095781a 
libgit2 was updated in eb7aa55.
Upstream still uses v30 of git2go, the go bindings for libgit2 1.0.x. There is
an open issue regarding libgit2 1.1.0 support here:
https://gitlab.com/gitlab-org/gitaly/-/issues/3330
Until this is solved we include a patch.
@ghost
Copy link
Author

ghost commented Dec 26, 2020

This was handled by #107558

@ghost ghost closed this Dec 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants