Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.PyChromecast: 7.5.1 -> 7.7.1 #107964

Merged
merged 4 commits into from Dec 30, 2020
Merged

python3Packages.PyChromecast: 7.5.1 -> 7.7.1 #107964

merged 4 commits into from Dec 30, 2020

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 30, 2020

Motivation for this change

Update to latest upstream release 7.7.1.

  • Requires also an update for paste to 3.5.0.
  • pythonImportsCheck was added
  • Atrributes were updated
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar December 30, 2020 12:38
@fabaff
Copy link
Member Author

fabaff commented Dec 30, 2020

Result of nixpkgs-review pr 107964 1

15 packages built:
  • catt
  • gnomecast
  • mkchromecast
  • python37Packages.PyChromecast
  • python37Packages.paste
  • python37Packages.poster3
  • python37Packages.sqlobject
  • python38Packages.PyChromecast
  • python38Packages.paste
  • python38Packages.poster3
  • python38Packages.sqlobject
  • python39Packages.PyChromecast
  • python39Packages.paste
  • python39Packages.poster3
  • python39Packages.sqlobject

@prusnak prusnak merged commit e92cc61 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @prusnak