Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colmap: 3.5 -> 3.6 and fix colmapWithCuda build #107962

Merged
merged 2 commits into from Jan 4, 2021
Merged

Colmap: 3.5 -> 3.6 and fix colmapWithCuda build #107962

merged 2 commits into from Jan 4, 2021

Conversation

flyfloh
Copy link
Contributor

@flyfloh flyfloh commented Dec 30, 2020

Motivation for this change

#99098

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lebastr December 30, 2020 12:27
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107962 run on x86_64-linux 1

2 packages built:
  • colmap
  • colmapWithCuda

blitz
blitz approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that colmap and colmapWithCuda build and run.

@SuperSandro2000 Let's get this merged!

@blitz blitz requested a review from tfc January 3, 2021 13:22
@SuperSandro2000 SuperSandro2000 merged commit 6ac4c2d into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@blitz blitz blitz approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@lebastr lebastr Awaiting requested review from lebastr

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flyfloh @SuperSandro2000 @tfc @blitz