Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytest-datafiles: Update homepage #107362

Merged
merged 1 commit into from Dec 30, 2020

Conversation

edmundmiller
Copy link
Contributor

Motivation for this change

Found a wrong link in the documentation of a package

Things done

Updated it

@SuperSandro2000
Copy link
Member

We fetch from pypi so I think this homepage is correct. Also next time please target master and set the title and commit message according to the contribution guide.

@edmundmiller
Copy link
Contributor Author

@SuperSandro2000 Sorry about those just wanted to get the fix in. I thought they were updated from pypi, but it seems like it didn't work out on this one. https://pypi.org/project/pytest-datafiles/ should be the correct pypi link, as you can see the old one doesn't match up with the package name from what I can tell. I'll fix my lack of etiquette if you agree that the current link is incorrect, and change the link to a pypi link instead of gh otherwise feel free to close this.

@SuperSandro2000
Copy link
Member

Oh yeah. You are right. Can you change the title and commit message to python3Packages.pytest-datafiles: Update homepage

@edmundmiller edmundmiller changed the title Fix pytest-datafiles homepage python3Packages.pytest-datafiles: Update homepage Dec 23, 2020
@edmundmiller
Copy link
Contributor Author

@SuperSandro2000 Should be good now! Let me know if you need anything else!

@SuperSandro2000
Copy link
Member

Please target master which I could merge.

@edmundmiller edmundmiller changed the base branch from nixos-unstable to master December 24, 2020 16:23
@edmundmiller
Copy link
Contributor Author

@SuperSandro2000 Sorry I didn't ping you on this. Should be good to go.

@jonringer jonringer merged commit 34415ec into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants