go_1_16: init at 1.16 #107937
go_1_16: init at 1.16 #107937
Conversation
ofborg
bot
requested review from
Frostman,
mdlayher,
rvolosatovs and
cstrahan
|
Built on darwin. |
|
Updated to
|
|
Updated the cc @adisbladis |
|
Either this or #112248 will need a rebase once one of them is merged. |
| ++ optionals stdenv.isLinux [ stdenv.cc.libc.out ] | ||
| ++ optionals (stdenv.hostPlatform.libc == "glibc") [ stdenv.cc.libc.static ]; | ||
|
|
||
| depsTargetTargetPropagated = optionals stdenv.isDarwin [ Security Foundation ]; |
There was a problem hiding this comment.
I think you also need the following for 1.16 (plus xcbuild in inputs):
propagatedBuildInputs = optionals stdenv.isDarwin [ xcbuild ];
See: golang/go@7e25bdb
Otherwise you won't be able to link packages inside of Nix build environment:
/nix/store/61kpq6gcyp94j87ni6i12vl4vpmsgb02-go-1.16rc1/share/go/pkg/tool/darwin_amd64/link: /nix/store/61kpq6gcyp94j87ni6i12vl4vpmsgb02-go-1.16rc1/share/go/pkg/tool/darwin_amd64/link: running dsymutil failed: exec: "xcrun": executable file not found in $PATH
Go will still work outside of Nix if you run go, because it will find /usr/bin/xcrun from developer tools.
|
Please update to reflect the removal of go_bootstrap in #113113 |
|
Changes from #112248 should also be picked up. |
|
Good to merge now? I can address #107937 (comment) in a separate PR. |
I was going to wait until 1.16 is released and merge that. |
|
Seems reasonable to incorporate my change to not break darwin down to road then. |
|
Today is the day: https://github.com/golang/go/releases/tag/go1.16. The source file is already available at the expected URL, even if https://golang.org/dl/ is not yet updated. |
Changes are minor - I ended up just patching the ssl certs at the root file, rather than trying to keep up with the various darwin changes. The externalnetwork test helper location changed, to so I had to update that patch as well. - Add xcbuild as propagatedBuildInput on darwin golang/go@7e25bdb
It's been updated.
Added |
|
LGTM. |
|
Built on |
This allows us to sort out go1.16 in time for its release.
Changes are minor - I ended up just patching the ssl certs at the root
file, rather than trying to keep up with the various darwin changes.
The externalnetwork test helper location changed, to so I had to update
that patch as well.
Motivation for this change
go1.16beta1 is available - go1.16 should drop in febuary.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)