Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-tado: init at 0.9.0 #107956

Merged
merged 2 commits into from Dec 30, 2020
Merged

pythonPackages.python-tado: init at 0.9.0 #107956

merged 2 commits into from Dec 30, 2020

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Dec 30, 2020 •
edited

Motivation for this change

Support tado integration in Home Assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one

pkgs/development/python-modules/python-tado/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107956 run on x86_64-linux 1

3 packages built:
  • python37Packages.python-tado
  • python38Packages.python-tado
  • python39Packages.python-tado

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107956 run on x86_64-darwin 1

3 packages built:
  • python37Packages.python-tado
  • python38Packages.python-tado
  • python39Packages.python-tado

@prusnak prusnak merged commit 2435d5e into NixOS:master Dec 30, 2020
@JamieMagee JamieMagee deleted the python-tado branch December 24, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamieMagee @SuperSandro2000 @prusnak