Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b00b8f07ac2f
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3b8c5e99901d
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Dec 29, 2020

  1. displaylink: manually activate dlm.service 

    The shell script coming with the vendor-provided udev rule simply
starts dlm.service (and sets up some symlinks), and stops dlm.service if
that was the last card plugged in.

On NixOS, some of the cat/grep/sed commands are not available, causing
the script to fail.

Turns out, the symlinks aren't needed at all. Archlinux ships their own
script
(https://aur.archlinux.org/cgit/aur.git/plain/udev.sh?h=displaylink),
which only starts and stops dlm.service, depending on whether there's
cards left or not.

We can further optimize this by simply starting dlm.service on the first
card, and not stopping it at all. Considering dlm won't get stopped if
one of multiple cards is unplugged, it seems to handle disconnects.

(cherry picked from commit 43f7479)
    @flokli @peterhoeg
    flokli authored and peterhoeg committed Dec 29, 2020
    Copy the full SHA
    3b8c5e9 View commit details
    Browse the repository at this point in the history