Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiramisu: init at 1.0 #107917

Merged
merged 1 commit into from Dec 30, 2020
Merged

tiramisu: init at 1.0 #107917

merged 1 commit into from Dec 30, 2020

Conversation

wishfort36
Copy link
Contributor

Motivation for this change

This package is a notification daemon that prints notifications to stdout - allowing the user process notifications as they wish, for example by integrating it in their existing statusbar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Arch)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note: I've added this:

postPatch = ''
  sed -i 's/printf(element_delimiter)/printf("%s", element_delimiter)/' src/output.c
'';

because gcc refuses to compile, erroring at line no. 88 in src/output.c:

              printf(element_delimiter);

(Furthermore, this happens on gcc 9.3.0 (NixOS), but not on gcc 10.2.0 (Arch), when compiling the normal way.). I'm not sure if this strategy is the best way to make it compile, so if anyone knows a better or more idiomatic way, then please tell!

pkgs/applications/misc/tiramisu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tiramisu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tiramisu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tiramisu/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107917 run on x86_64-linux 1

1 package marked as broken and skipped:
  • tiramisu

@wishfort36
Copy link
Contributor Author

I've committed and squashed your suggestions, @prusnak.

@wishfort36
Copy link
Contributor Author

I'm not sure exactly why nixpkgs-review would fail, particularly because I can't figure out how to make it tell me. I saw that ofborg failed a test because i misspelled longDescription, so I've fixed that now. Let's hope it doesn't fail now.

@wishfort36
Copy link
Contributor Author

Result of nixpkgs-review pr 107917 run on x86_64-linux 1

1 package built:
  • tiramisu

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107917 run on x86_64-linux 1

1 package built:
  • tiramisu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants