Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cntr: 1.2.1 -> 1.4.1 #107942

Merged
merged 1 commit into from Dec 30, 2020
Merged

cntr: 1.2.1 -> 1.4.1 #107942

merged 1 commit into from Dec 30, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 30, 2020 •
edited

Motivation for this change

cc @BBBSnowball

fixes aarch64 build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Dec 30, 2020
Closed
@BBBSnowball
Copy link
Contributor

Thanks :-)

Can you enable aarch64-linux in meta.platforms, please?

@Mic92
Copy link
Member Author

Mic92 commented Dec 30, 2020

done.

@BBBSnowball
Copy link
Contributor

works on x86_64 and aarch64:

$ nix run github:NixOS/nixpkgs/f91d7cf059f4eb7825214febba7b4ddf003e34ea#cntr
Usage:
  /nix/store/spn5ca2a84wwwpc5x5bnklizbvjhzk1k-cntr-1.4.1/bin/cntr COMMAND [ARGUMENTS ...]
/nix/store/spn5ca2a84wwwpc5x5bnklizbvjhzk1k-cntr-1.4.1/bin/cntr: Argument command is required

@Mic92 Mic92 merged commit 4e84448 into NixOS:master Dec 30, 2020
@Mic92 Mic92 deleted the cntr branch December 30, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @BBBSnowball