Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librepo: enable zchunk support on darwin #107972

Merged
merged 1 commit into from Dec 30, 2020
Merged

librepo: enable zchunk support on darwin #107972

merged 1 commit into from Dec 30, 2020

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Dec 30, 2020 •
edited

Motivation for this change

Thanks to @nima2007 's work in #107443, we can now enable zchunk support on Darwin as well.
For Linux, this PR is a noop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 30, 2020

Result of nixpkgs-review pr 107972 run on x86_64-linux 1

@rb2k
Copy link
Contributor Author

rb2k commented Dec 30, 2020

Result of nixpkgs-review pr 107972 run on x86_64-darwin 1

6 packages built:
  • libdnf
  • librepo
  • microdnf
  • python37Packages.librepo
  • python38Packages.librepo
  • python39Packages.librepo

@rb2k rb2k requested a review from copumpkin December 30, 2020 15:17
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Dec 30, 2020
@rb2k rb2k mentioned this pull request Dec 30, 2020
Merged
@prusnak prusnak merged commit 6c71f43 into NixOS:master Dec 30, 2020
@nima2007 nima2007 mentioned this pull request Dec 30, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rb2k @prusnak