Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.r2pipe: Fix build #107973

Merged
merged 1 commit into from Jan 10, 2021
Merged

pythonPackages.r2pipe: Fix build #107973

merged 1 commit into from Jan 10, 2021

Conversation

aszlig
Copy link
Member

@aszlig aszlig commented Dec 30, 2020 •
edited

Regression introduced by 6556711.

The string start and end quoting styles have changed in the upstream source code between version 1.4.2 and version 1.5.3, so the checkPhase now results in the following error:

======================================================================
ERROR: native (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: native
Traceback (most recent call last):
  File ".../unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/build/r2pipe-1.5.3/r2pipe/native.py", line 113, in <module>
    class RCore(Structure):  # 1
  File "/build/r2pipe-1.5.3/r2pipe/native.py", line 125, in RCore
    cmd_str, r_core_cmd_str = register(
  File "/build/r2pipe-1.5.3/r2pipe/native.py", line 108, in register
    method = WrappedRMethod(cname, args, ret)
  File "/build/r2pipe-1.5.3/r2pipe/native.py", line 53, in __init__
    r2 = r2lib()
  File "/build/r2pipe-1.5.3/r2pipe/native.py", line 27, in r2lib
    raise ImportError("No native r_core library")
ImportError: No native r_core library

@aszlig aszlig requested review from FRidh and timokau December 30, 2020 15:11
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107973 1

3 packages built:
  • python37Packages.r2pipe
  • python38Packages.r2pipe
  • python39Packages.r2pipe

thiagokokada
thiagokokada reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the commit message please? It should be python3Packages.r2pipe: fix build.

SuperSandro2000
SuperSandro2000 requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit and PR title to pythonPackages.r2pipe: Fix build

@aszlig
Copy link
Member Author

aszlig commented Dec 31, 2020

Whoops, sorry, wasn't that awake anymore.

@aszlig aszlig changed the title python/r2pipe: Fix build pythonPackages.r2pipe: Fix build Dec 31, 2020
@aszlig
pythonPackages.r2pipe: Fix build
dfbedd6 
Regression introduced by 6556711.

The string start and end quoting styles have changed in the upstream
source code between version 1.4.2 and version 1.5.3, so the checkPhase
now results in the following error:

  ======================================================================
  ERROR: native (unittest.loader._FailedTest)
  ----------------------------------------------------------------------
  ImportError: Failed to import test module: native
  Traceback (most recent call last):
    File ".../unittest/loader.py", line 154, in loadTestsFromName
      module = __import__(module_name)
    File "/build/r2pipe-1.5.3/r2pipe/native.py", line 113, in <module>
      class RCore(Structure):  # 1
    File "/build/r2pipe-1.5.3/r2pipe/native.py", line 125, in RCore
      cmd_str, r_core_cmd_str = register(
    File "/build/r2pipe-1.5.3/r2pipe/native.py", line 108, in register
      method = WrappedRMethod(cname, args, ret)
    File "/build/r2pipe-1.5.3/r2pipe/native.py", line 53, in __init__
      r2 = r2lib()
    File "/build/r2pipe-1.5.3/r2pipe/native.py", line 27, in r2lib
      raise ImportError("No native r_core library")
  ImportError: No native r_core library

Signed-off-by: aszlig <aszlig@nix.build>
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107973 1

3 packages built:
  • python37Packages.r2pipe
  • python38Packages.r2pipe
  • python39Packages.r2pipe

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107973 run on x86_64-linux 1

3 packages built:
  • python37Packages.r2pipe
  • python38Packages.r2pipe
  • python39Packages.r2pipe

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.r2pipe.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.r2pipe.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.r2pipe.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107973 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.r2pipe
  • python38Packages.r2pipe
  • python39Packages.r2pipe

@aszlig
Copy link
Member Author

aszlig commented Jan 9, 2021

@SuperSandro2000: These warnings are all unrelated and not in scope for this PR (if we're going to start improving the package, we're speaking about a complete refactor), so can you please re-review for the scope of this PR?

jonringer
jonringer approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

still an improvement to nixpkgs :)

https://github.com/NixOS/nixpkgs/pull/107973

3 packages built:
python37Packages.r2pipe python38Packages.r2pipe python39Packages.r2pipe

@jonringer jonringer merged commit 97028f0 into NixOS:master Jan 10, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/github-block-evasion-is-not-acceptable/12763/67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@timokau timokau Awaiting requested review from timokau

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aszlig @thiagokokada @SuperSandro2000 @nixos-discourse @jonringer