Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.mirage: reintroduce dev output #107971

Merged
merged 1 commit into from Dec 30, 2020
Merged

ocamlPackages.mirage: reintroduce dev output #107971

merged 1 commit into from Dec 30, 2020

Conversation

sternenseemann
Copy link
Member

The changed dune install directive to install libraries to the dev
output was removed by mistake. cc @vbgl

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
ocamlPackages.mirage: reintroduce dev output
03d886c 
The changed dune install directive to install libraries to the dev
output was removed by mistake.
@vbgl
Copy link
Contributor

vbgl commented Dec 30, 2020

@GrahamcOfBorg build ocamlPackages.mirage

@vbgl vbgl merged commit caf07b0 into NixOS:master Dec 30, 2020
@vbgl
Copy link
Contributor

vbgl commented Dec 30, 2020

Thanks.

@sternenseemann sternenseemann deleted the mirage-readd-dev-ouput branch December 30, 2020 18:41
@sternenseemann sternenseemann restored the mirage-readd-dev-ouput branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl