Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin: add openFirewall option #107969

Merged
merged 1 commit into from Apr 10, 2021
Merged

jellyfin: add openFirewall option #107969

merged 1 commit into from Apr 10, 2021

Conversation

corngood
Copy link
Contributor

Motivation for this change

Plex has this, and it seems like a reasonable way of documenting these ports.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

minijackson
minijackson reviewed Dec 31, 2020
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

At first I was a little mixed on this PR, since the port is not configurable through Nix, but then this PR made me aware of other ports used by Jellyfin (I was happily using it with just 8096 open), so now I think this PR is useful even if just for discovery purposes. So I think documenting that will prevent some misconceptions.

nixos/modules/services/misc/jellyfin.nix Outdated
type = types.bool;
default = false;
description = ''
Open ports in the firewall for the media server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document the fact that it will open the default ports, and if changed in the webui, this option will not entirely work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise you could set them there. Updated. Thanks

@minijackson
Copy link
Member

@ofborg test jellyfin

@minijackson
Copy link
Member

Hey, I can control ofborg now! 🎉

@berbiche
Copy link
Member

Update?

@minijackson
Copy link
Member

/marvin opt-in

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/364

aanderse
aanderse approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, not a perfect change, but a highly practical change.

👍

@aanderse aanderse merged commit e0fd737 into NixOS:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

@minijackson minijackson minijackson approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@corngood @minijackson @berbiche @nixos-discourse @Emantor @aanderse