-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mathematica_test a little less brittle #2829
Make mathematica_test a little less brittle #2829
Conversation
mathematica/mathematica_test.cpp
Outdated
"SetPrecision[+2.00000000000000000*^+00,$MachinePrecision]," | ||
"SetPrecision[+3.00000000000000000*^+00,$MachinePrecision]]", | ||
ToMathematica(std::vector<double>{2, 3})); | ||
EXPECT_EQ("List[" + ToMathematica(2.0) + "," + ToMathematica(3.0) + "]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to preserve a formatting closer to the original one: (1) line break after [
(2) line break after ,
(3) line break after the (replacement for) the SetPrecision
call, i.e., after the +
(unless followed by a comma). The clang-format
formatting makes it hard to visually parse the structure.
@@ -31,12 +31,12 @@ FORWARD_DECLARE_FUNCTION_FROM( | |||
mathematica, | |||
TEMPLATE(typename Value, typename Argument, int degree_, | |||
template<typename, typename, int> typename Evaluator, | |||
typename OptionalExpressIn = std::nullopt_t) std::string, | |||
typename OptionalExpressIn) std::string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fishy. Similar declarations exist in poisson_series.hpp
and piecewise_poisson_series.hpp
, so I presume that they would need changing too. As a matter of fact, it's seems better to have the default live in mathematica
than in distant units that happen to have a forward declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar declarations exist in
poisson_series.hpp
andpiecewise_poisson_series.hpp
They don’t (they don’t have defaults).
As a matter of fact, it's seems better to have the default live in
mathematica
than in distant units that happen to have a forward declaration.
This is what this pull request does.
retest this please |
No description provided.