Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-modules.weasyprint: 50 -> 52 #107976

Merged
merged 1 commit into from Jan 4, 2021
Merged

python-modules.weasyprint: 50 -> 52 #107976

merged 1 commit into from Jan 4, 2021

Conversation

ali-abrar
Copy link
Contributor

@ali-abrar ali-abrar commented Dec 30, 2020 •
edited

Motivation for this change

Updating weasyprint to the latest major upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from elohmeier December 30, 2020 16:21
thiagokokada
thiagokokada reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename commit to pythonPackages.weasyprint: 50 -> 52.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107976 1

4 packages failed to build:
  • python37Packages.xml2rfc
  • xml2rfc (python38Packages.xml2rfc)
  • python39Packages.weasyprint
  • python39Packages.xml2rfc
3 packages built:
  • python37Packages.weasyprint
  • python38Packages.weasyprint
  • sourcehut.metasrht

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107976 run on x86_64-darwin 1

7 packages failed to build:
  • python37Packages.weasyprint
  • python37Packages.xml2rfc
  • python38Packages.weasyprint
  • xml2rfc (python38Packages.xml2rfc)
  • python39Packages.weasyprint
  • python39Packages.xml2rfc
  • sourcehut.metasrht

weasyprint:

File "/nix/store/1pmbm2hpjvll1kmaz8c5njkh753sqfkj-python3.7-pytest-6.1.2/bin/.pytest-wrapped", line 9 in
/nix/store/2kq3igrr75pj6nay6phchgn5x1z1f30z-stdenv-darwin/setup: line 1317: 49611 Segmentation fault: 11 pytest -k 'not test_font_stretch'

python3.8-pgpy:
tests fail on sandbox due to network access

python-3.8-cfn-lint:
FAILED test/integration/test_quickstart_templates.py::TestQuickStartTemplates::test_templates
FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_module_integration
FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_templates
================== 3 failed, 497 passed, 1 warning in 59.83s ===================

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107976 run on x86_64-linux 1

1 packages failed to build and are new build failures:
  • python37Packages.xml2rfc
  • xml2rfc
  • (python38Packages.xml2rfc)
  • python39Packages.weasyprint
  • python39Packages.xml2rfc
  • sourcehut.metasrht
2 packages built:
  • python37Packages.weasyprint
  • python38Packages.weasyprint

ERROR: Could not find a version that satisfies the requirement configargparse>=1.2.3 (from xml2rfc)
ERROR: No matching distribution found for configargparse>=1.2.3

ERROR: Could not find a version that satisfies the requirement appdirs>=1.4.4 (from xml2rfc)
ERROR: No matching distribution found for appdirs>=1.4.4

builder for '/nix/store/kmal5zpm1217y34316g3gcq8c2w3avs1-python3.8-cfn-lint-0.35.1.drv' failed with exit code 1; last 10 log lines:
test/unit/rules/functions/test_sub_needed.py:30
/build/source/test/unit/rules/functions/test_sub_needed.py:30: DeprecationWarning: invalid escape sequence $
{'custom_excludes': '^${self.+}$'}, 0

		  -- Docs: https://docs.pytest.org/en/stable/warnings.html
		    =========================== short test summary info ============================
			  FAILED test/integration/test_quickstart_templates.py::TestQuickStartTemplates::test_templates
			    FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_module_integration
				  FAILED test/integration/test_quickstart_templates_non_strict.py::TestQuickStartTemplates::test_templates
				    ================== 3 failed, 497 passed, 1 warning in 48.01s ===================
					cannot build derivation '/nix/store/65crvik6h3fh53fdi79p87xvwpcqmvm8-python3.8-moto-1.3.14.drv': 1 dependencies couldn't be buil

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 4, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107976 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.xml2rfc
1 package failed to build and are new build failure:
  • python39Packages.weasyprint: log was empty
5 packages built:
  • python37Packages.weasyprint
  • python37Packages.xml2rfc
  • python38Packages.weasyprint
  • xml2rfc (python38Packages.xml2rfc)
  • sourcehut.metasrht

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

sourcehut.metasrht:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

Python 3.9 build failure is unrelated.

@SuperSandro2000 SuperSandro2000 merged commit 9bf1701 into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@elohmeier elohmeier Awaiting requested review from elohmeier

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ali-abrar @thiagokokada @SuperSandro2000