Fix: Assert fail when using restart command after opening save/load GUI #8464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Use of the
restart
console command and network auto-restarting (NetworkCheckRestartMap
) after opening the save/load window triggers an assertion failure.Example reproduction steps:
restart
in the consoleDescription
ShowSaveLoadDialog
incorrectly overwrites the value of_file_to_saveload.abstract_ftype
.This value is used by the
restart
console command and byNetworkCheckRestartMap
.The value of the
_file_to_saveload.abstract_ftype
must be consistent with the other members of_file_to_saveload
.Limitations
N/A
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.