Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groff: fix static build #107927

Merged
merged 1 commit into from Jan 2, 2021
Merged

groff: fix static build #107927

merged 1 commit into from Jan 2, 2021

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Dec 29, 2020

Without manual override following problematic code in generated
"configure" script (line 15918):

case "$host_os" in
# Guess yes on glibc systems.
-gnu | gnu*) gl_cv_func_signbit="guessing yes" ;;
# Guess yes on native Windows.
mingw*) gl_cv_func_signbit="guessing yes" ;;
# If we don't know, assume the worst.
*) gl_cv_func_signbit="guessing no" ;;
esac

results in declaration conflict with gnulib declaring

int signbit(double)

while system "math.h" providing modern declaration as

constexpr bool signbit(double)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Without manual override following problematic code in generated
"configure" script (line 15918):

  case "$host_os" in
    # Guess yes on glibc systems.
    *-gnu* | gnu*) gl_cv_func_signbit="guessing yes" ;;
    # Guess yes on native Windows.
    mingw*)        gl_cv_func_signbit="guessing yes" ;;
    # If we don't know, assume the worst.
    *)             gl_cv_func_signbit="guessing no" ;;
  esac

results in declaration conflict with gnulib declaring

  int signbit(double)

while system "math.h" providing modern declaration as

  constexpr bool signbit(double)
@KAction
Copy link
Contributor Author

KAction commented Jan 1, 2021

@samueldr @FRidh Merge, please?

@FRidh FRidh merged commit a8040c7 into NixOS:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants