Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rtl8821cu for Linux 5.10 support #107351

Merged
merged 1 commit into from Dec 30, 2020
Merged

Bump rtl8821cu for Linux 5.10 support #107351

merged 1 commit into from Dec 30, 2020

Conversation

srid
Copy link
Contributor

@srid srid commented Dec 21, 2020 •
edited

This makes rtl8821cu build on pkgs.linuxPackages_latest

Motivation for this change

Fix rtl8821cu driver to work on latest kernel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srid
Bump rtl8821cu for Linux 5.10 support
a933178 
This makes rtl8821cu build on pkgs.linuxPackages_latest
@srid
Copy link
Contributor Author

srid commented Dec 21, 2020

Ping @contrun @NeQuissimus

@ofborg ofborg bot requested a review from contrun December 21, 2020 22:23
r-burns
r-burns approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 107351 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.rtl8821cu
  • linuxPackages_hardkernel_latest.rtl8821cu
17 packages built:
  • linuxPackages-libre.rtl8821cu
  • linuxPackages.rtl8821cu (linuxPackages_5_4.rtl8821cu)
  • linuxPackages_4_14.rtl8821cu
  • linuxPackages_4_19.rtl8821cu
  • linuxPackages_4_4.rtl8821cu
  • linuxPackages_4_9.rtl8821cu
  • linuxPackages_5_10.rtl8821cu (linuxPackages_latest.rtl8821cu)
  • linuxPackages_5_9.rtl8821cu
  • linuxPackages_hardened.rtl8821cu
  • linuxPackages_latest-libre.rtl8821cu
  • linuxPackages_latest_hardened.rtl8821cu
  • linuxPackages_latest_xen_dom0.rtl8821cu
  • linuxPackages_latest_xen_dom0_hardened.rtl8821cu
  • linuxPackages_testing_bcachefs.rtl8821cu
  • linuxPackages_xen_dom0.rtl8821cu
  • linuxPackages_xen_dom0_hardened.rtl8821cu
  • linuxPackages_zen.rtl8821cu

@srid
Copy link
Contributor Author

srid commented Dec 22, 2020 •
edited

Sadly, this version of the driver crashes (at random times) the kernel on X1C7:

dmesg log 
Dec 21 17:43:18 bebe kernel: BUG: unable to handle page fault for address: ffffe1a423150348
Dec 21 17:43:18 bebe kernel: #PF: supervisor read access in kernel mode
Dec 21 17:43:18 bebe kernel: #PF: error_code(0x0000) - not-present page
Dec 21 17:43:18 bebe kernel: PGD 0 P4D 0
Dec 21 17:43:18 bebe kernel: RBP: ffffe09bc540d440 R08: 00000000000001f4 R09: 0000000000000000
Dec 21 17:43:18 bebe kernel: R10: 0000000000000000 R11: 0000000000000008 R12: ffffe1a423150340
Dec 21 17:43:18 bebe kernel: R13: ffffe09b4540d440 R14: 0000000000000005 R15: 0000000000000000
Dec 21 17:43:18 bebe kernel: FS:  0000000000000000(0000) GS:ffff9e66f0780000(0000) knlGS:0000000000000000
Dec 21 17:43:18 bebe kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Dec 21 17:43:18 bebe kernel: CR2: ffffe1a423150348 CR3: 00000001c1b48005 CR4: 00000000003706e0
Dec 21 17:43:18 bebe kernel: Call Trace:
Dec 21 17:43:18 bebe kernel:  usb_control_msg+0xfd/0x140 [usbcore]
Dec 21 17:43:18 bebe kernel:  usbctrl_vendorreq+0x2be/0x402 [8821cu]
Dec 21 17:43:18 bebe kernel:  usb_read8+0x3e/0x5d [8821cu]
Dec 21 17:43:18 bebe kernel:  _rtw_read8+0x1b/0x1c [8821cu]
Dec 21 17:43:18 bebe kernel:  _halmac_reg_read_8+0x11/0x12 [8821cu]
Dec 21 17:43:18 bebe kernel:  reg_r8_usb_88xx+0x1f/0x20 [8821cu]
Dec 21 17:43:18 bebe kernel:  pinmux_wl_led_sw_ctrl_88xx+0x27/0x51 [8821cu]
Dec 21 17:43:18 bebe kernel: CR2: ffffe1a423150348 CR3: 00000001c1b48005 CR4: 00000000003706e0
Dec 21 17:43:18 bebe kernel: Call Trace:
Dec 21 17:43:18 bebe kernel:  usb_control_msg+0xfd/0x140 [usbcore]
Dec 21 17:43:18 bebe kernel:  usbctrl_vendorreq+0x2be/0x402 [8821cu]
Dec 21 17:43:18 bebe kernel:  usb_read8+0x3e/0x5d [8821cu]
Dec 21 17:43:18 bebe kernel:  _rtw_read8+0x1b/0x1c [8821cu]
Dec 21 17:43:18 bebe kernel:  _halmac_reg_read_8+0x11/0x12 [8821cu]
Dec 21 17:43:18 bebe kernel:  reg_r8_usb_88xx+0x1f/0x20 [8821cu]
Dec 21 17:43:18 bebe kernel:  pinmux_wl_led_sw_ctrl_88xx+0x27/0x51 [8821cu]
Dec 21 17:43:18 bebe kernel:  rtw_halmac_led_switch+0x23/0x24 [8821cu]
Dec 21 17:43:18 bebe kernel:  swledon+0x4c/0x4e [8821cu]
Dec 21 17:43:18 bebe kernel:  SwLedBlink9+0xb0/0x7aa [8821cu]
Dec 21 17:43:18 bebe kernel:  BlinkHandler+0x114/0x178 [8821cu]
Dec 21 17:43:18 bebe kernel:  BlinkWorkItemCallback+0xe/0xf [8821cu]
Dec 21 17:43:18 bebe kernel:  process_one_work+0x1df/0x370
Dec 21 17:43:18 bebe kernel:  worker_thread+0x4d/0x3e0
Dec 21 17:43:18 bebe kernel:  ? process_one_work+0x370/0x370
Dec 21 17:43:18 bebe kernel:  kthread+0xfe/0x140
Dec 21 17:43:18 bebe kernel:  ? kthread_park+0x90/0x90
Dec 21 17:43:18 bebe kernel:  ret_from_fork+0x1f/0x30

So, I'm going back to 5.9. :-/

@srid
Copy link
Contributor Author

srid commented Dec 29, 2020

Sadly, this version of the driver crashes (at random times) the kernel on X1C7:

Haven't happened since using kernel 5.10.2, for what it's worth. So I'd approve merging this to master.

@NeQuissimus NeQuissimus merged commit 9b3ad00 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@r-burns r-burns r-burns approved these changes

@contrun contrun Awaiting requested review from contrun

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srid @NeQuissimus @r-burns