Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libquotient: 0.6.2 -> 0.6.3 #107919

Merged
merged 3 commits into from Dec 29, 2020
Merged

libquotient: 0.6.2 -> 0.6.3 #107919

merged 3 commits into from Dec 29, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upstream update but adding on a few minor changes:

  1. fix neochat's version tag
  2. add maintainer to neochat (@mjlbach - I didn't want to just add you without your consent)
  3. upgrade quaternion to the latest beta. Yes, we normally don't do that but:
  4. it is needed to compile against libquotient v0.6+
  5. quaternion is still a young product without a stable v1.0 release so this version isn't necessarily any less stable than the previous
  6. I have been using the beta2 version since release without any issues
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build neochat quaternion

@mjlbach
Copy link
Contributor

mjlbach commented Dec 29, 2020

1 and 2 look good to me! I haven't used quaternion for a large extent of time, so I can't comment on that. Happy to also be added/help maintain neochat (I haven't added myself to the master maintainers list yet though).

@peterhoeg peterhoeg merged commit 920a721 into NixOS:master Dec 29, 2020
@peterhoeg peterhoeg deleted the u/libquotient branch December 29, 2020 22:51
@peterhoeg
Copy link
Member Author

Thanks for the feedback and welcome onboard!

I suggest you open a PR with 2 commits - one adding yourself to the maintainer list and the other adding yourself to neochat (I suggest you add yourself to the head of the list as you were the one who got it up and running).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens Awaiting requested review from colemickens

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @mjlbach