Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b85bb14ea703
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5912b3a2b3e0
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Dec 30, 2020

  1. Copy the full SHA
    6e2d3bf View commit details
  2. Remove stray files.

    pleroy committed Dec 30, 2020

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    db2fbfd View commit details
  3. Merge pull request #2832 from pleroy/Clang

    Ifdef out a test that fails to compile with Clang
    pleroy authored Dec 30, 2020
    Copy the full SHA
    5912b3a View commit details
Showing with 7 additions and 0 deletions.
  1. +7 −0 numerics/polynomial_test.cpp
7 changes: 7 additions & 0 deletions numerics/polynomial_test.cpp
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@

#include <tuple>

#include "base/macros.hpp"
#include "geometry/frame.hpp"
#include "geometry/grassmann.hpp"
#include "geometry/named_quantities.hpp"
@@ -266,6 +267,11 @@ TEST_F(PolynomialTest, Ring) {
}
}

// Compose contains a fold expression which fails to compile in Clang because of
// https://bugs.llvm.org/show_bug.cgi?id=30590. That bug will be fixed post-
// 11.0.0. Since we don't use Compose as of this writing, and working around
// the bug would be hard, we ifdef out the test.
#if PRINCIPIA_COMPILER_MSVC
TEST_F(PolynomialTest, Monoid) {
using P2A =
PolynomialInMonomialBasis<Temperature, Instant, 2, HornerEvaluator>;
@@ -317,6 +323,7 @@ TEST_F(PolynomialTest, Monoid) {
EXPECT_THAT(actual_v, AlmostEquals(-46396 * Ampere, 0));
}
}
#endif

TEST_F(PolynomialTest, PointwiseInnerProduct) {
P2V::Coefficients const coefficients({