Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/ssmtp: fix configuration generator to accomodate ssmtp #107949

Merged
merged 1 commit into from Dec 30, 2020
Merged

[20.09] nixos/ssmtp: fix configuration generator to accomodate ssmtp #107949

merged 1 commit into from Dec 30, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Dec 30, 2020 •
edited

Motivation for this change

This replaces concatStringsSep "\n" with the proper generator to make sure
that the generated configuration file ends with a trailing \n, which is
required by ssmtp's picky configuration parser to take the last configuration
key into account.

GitHub: closes #105704
(cherry picked from commit a2c4419)

This is a backport of #105706.
CC @AndersonTorres (#105706 (comment))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested replacing the module locally
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
nixos/ssmtp: fix configuration generator to accomodate ssmtp
ece8d0f 
This replaces `concatStringsSep "\n"` with the proper generator to make sure
that the generated configuration file ends with a trailing `\n`, which is
required by ssmtp's picky configuration parser to take the last configuration
key into account.

GitHub: closes NixOS#105704
(cherry picked from commit a2c4419)
@AndersonTorres AndersonTorres merged commit 267772b into NixOS:release-20.09 Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @AndersonTorres