Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-file-transfer: 4.1 -> 4.2 #107950

Merged
merged 2 commits into from Dec 31, 2020
Merged

android-file-transfer: 4.1 -> 4.2 #107950

merged 2 commits into from Dec 31, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Dec 30, 2020

Motivation for this change

new release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 30, 2020 •
edited

Result of nixpkgs-review pr 107950 1

1 package built:
  • android-file-transfer

Builds fine, tested with my Samsung Galaxy S20 and it seems to work.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107950 run on x86_64-linux 1

1 package built:
  • android-file-transfer

lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 30, 2020

looks like LGPL-2.1+ to me (see the header of cli/Command.cpp for example)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107950 run on x86_64-linux 1

1 package built:
  • android-file-transfer

@SuperSandro2000 SuperSandro2000 merged commit 68a8e7b into NixOS:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xaverdh @thiagokokada @SuperSandro2000