Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mypy: don't use mypyc on 32-bit platforms #107947

Merged
merged 1 commit into from Dec 30, 2020
Merged

python3Packages.mypy: don't use mypyc on 32-bit platforms #107947

merged 1 commit into from Dec 30, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Dec 30, 2020

Motivation for this change

Almost all i686-linux tests got blocked because of this problem:
https://hydra.nixos.org/eval/1638038#tabs-now-fail
It regressed in PR #105462 (commit ad26cb9).

Things done

Now I tested that at least some test got fixed:
nix build -f nixos/release-combined.nix nixos.tests.knot.i686-linux
This change won't even cause any rebuild on 64-bit platforms,
and using nix booleans seems nicer anyway.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
python3Packages.mypy: don't use mypyc on 32-bit platforms
3e40d6d 
Almost all i686-linux tests got blocked because of this problem:
  https://hydra.nixos.org/eval/1638038#tabs-now-fail
It regressed in PR NixOS#105462 (commit ad26cb9).

Now I tested that at least some test got fixed:
  nix build -f nixos/release-combined.nix nixos.tests.knot.i686-linux
This change won't even cause any rebuild on 64-bit platforms,
and using nix booleans seems nicer anyway.
@vcunat vcunat added 0.kind: regression Something that worked before working no longer 6.topic: testing Tooling for automated testing of packages and modules labels Dec 30, 2020
@vcunat vcunat requested review from ruuda and FRidh December 30, 2020 08:13
@vcunat
Copy link
Member Author

vcunat commented Dec 30, 2020

I don't know mypy(c), so I have no idea if this minimalistic approach with just switching one variable makes real sense.

@ofborg ofborg bot requested review from LnL7 and martingms December 30, 2020 08:22
@FRidh FRidh merged commit 95f685d into NixOS:master Dec 30, 2020
@vcunat vcunat deleted the p/nixos-tests-i686 branch December 30, 2020 14:20
@ruuda
Copy link
Contributor

ruuda commented Dec 31, 2020

I have no idea if this minimalistic approach with just switching one variable makes real sense.

It does, thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@ruuda ruuda Awaiting requested review from ruuda

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@martingms martingms Awaiting requested review from martingms

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: python 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @ruuda @FRidh