Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nix packages for Grafana plugins and allow declarative installation #107980

Merged
merged 6 commits into from Jan 1, 2021
Merged

Add Nix packages for Grafana plugins and allow declarative installation #107980

merged 6 commits into from Jan 1, 2021

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Dec 30, 2020

Motivation for this change

I want to have my system state specified in Nix, and in particular I'd also like to have the installed set of Grafana plugins specified declaratively.

This adds a smattering of some of the Grafana plugins published by the Grafana Labs folks, as well as including an updateScript for keeping them up to date automatically.

The nixos/grafana module is then extended with support for declaratively specifying the set of plugins to install, and a new NixOS test added to check that this functionality works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
grafanaPlugins: init
3ba1a06 
This contains the base infrastructure (including a basic update script)
for maintaining Grafana plugins inside Nix, which, in a subsequent
commit, will be used for allowing the NixOS Grafana module to
automatically install plugins.
@lukegb
grafanaPlugins.grafana-clock-panel: init at 1.1.1
007ae56
@lukegb
grafanaPlugins.grafana-piechart-panel: init at 1.6.1
ee4c056
@lukegb
grafanaPlugins.grafana-polystat-panel: init at 1.2.2
83d1835
@lukegb
grafanaPlugins.grafana-worldmap-panel: init at 0.3.2
fafe7b2
@lukegb
nixos/grafana: add support for declarative plugin installation
d0a9e1e
@lukegb
Copy link
Contributor Author

lukegb commented Dec 30, 2020

@ofborg test grafana
@ofborg build grafanaPlugins.grafana-clock-panel grafanaPlugins.grafana-piechart-panel grafanaPlugins.grafana-polystat-panel grafanaPlugins.grafana-worldmap-panel

WilliButz
WilliButz approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution 🎉

@WilliButz WilliButz merged commit a4960d4 into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @WilliButz