Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyftdi: 0.51.2 -> 0.52.0 #107982

Merged
merged 2 commits into from Jan 1, 2021
Merged

python3Packages.pyftdi: 0.51.2 -> 0.52.0 #107982

merged 2 commits into from Jan 1, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 30, 2020

Motivation for this change

Update to latest upstream release 0.52.0

Disable the tests as they require access to the serial port and fail.

======================================================================
ERROR: protocol_unix (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: protocol_unix
Traceback (most recent call last):
  File "/nix/store/m7080pw0ryjk0jhljp55rq1hd2qy8gki-python3-3.8.6/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/build/source/pyftdi/serialext/protocol_unix.py", line 32, in <module>
    from serial import (SerialBase, SerialException, portNotOpenError,
ImportError: cannot import name 'portNotOpenError' from 'serial' (/nix/store/ivmwqcnbzarm1gh430hwhbwy3bpb34yy-python3.8-pyserial-3.5/lib/python3.8/site-packages/serial/__init__.py)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Dec 30, 2020

Result of nixpkgs-review pr 107982 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107982 run on x86_64-darwin 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107982 run on x86_64-linux 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107982 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

jonringer
jonringer reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or do meta = with lib; {

pkgs/development/python-modules/pyftdi/default.nix Show resolved Hide resolved
@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 107982 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

Just FYI, this is another case of a Python package that has .py extension in the files in the bin. I think eventually it would be nice to fix this (not in this PR).

@fabaff fabaff mentioned this pull request Dec 31, 2020
Open
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107982 run on x86_64-darwin 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107982 run on x86_64-linux 1

6 packages built:
  • python37Packages.alarmdecoder
  • python37Packages.pyftdi
  • python38Packages.alarmdecoder
  • python38Packages.pyftdi
  • python39Packages.alarmdecoder
  • python39Packages.pyftdi

@SuperSandro2000 SuperSandro2000 merged commit 9d0722f into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer left review comments

@thiagokokada thiagokokada thiagokokada approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @SuperSandro2000 @thiagokokada @jonringer