Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 2020.12.1 -> 2020.12.2 #107975

Merged
merged 3 commits into from Dec 30, 2020
Merged

home-assistant: 2020.12.1 -> 2020.12.2 #107975

merged 3 commits into from Dec 30, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/home-assistant/core/releases/tag/2020.12.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
homeassistant: 2020.12.1 -> 2020.12.2
097b35b
@mweinelt
python3Packages.HAP-python: 3.0.0 -> 3.1.0
c8be639 
Convert tests to pyTestCheckHook.
@mweinelt
python3Packages.denonavr: 0.9.3 -> 0.9.9
d8494df 
Disable on Python 2.7, convert tests to pytestCheckHook.
@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 30, 2020 •
edited

Result of nixpkgs-review pr 107975 1

1 package failed to build:
  • python39Packages.denonavr
6 packages built:
  • home-assistant
  • python37Packages.HAP-python
  • python37Packages.denonavr
  • python38Packages.HAP-python
  • python38Packages.denonavr
  • python39Packages.HAP-python

denonavr doesn't build with Python 3.9 but builds with older Pythons. Looks like an upstream issue, should we report it and disable the build of denonavr on Python 3.9 🤔 ?

But approving it anyway since the default Python is 3.8 so it should be ok.

thiagokokada
thiagokokada reviewed Dec 30, 2020
View reviewed changes
pkgs/development/python-modules/HAP-python/default.nix
@@ -1,16 +1,16 @@
{ lib, buildPythonPackage, fetchFromGitHub, isPy3k, curve25519-donna, ed25519
, cryptography, ecdsa, zeroconf, pytest }:
, cryptography, ecdsa, zeroconf, pytestCheckHook }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, very nice 👍 .

@mweinelt
Copy link
Member Author

mweinelt commented Dec 30, 2020 •
edited

denonavr doesn't build with Python 3.9 but builds with older Pythons. Looks like an upstream issue, should we report it and disable the build of denonavr on Python 3.9 thinking ?

Thanks, reported in ol-iver/denonavr#179.

jonringer
jonringer approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/107975

1 package failed to build:
python39Packages.denonavr

6 packages built:
home-assistant python37Packages.HAP-python python37Packages.denonavr python38Packages.HAP-python python38Packages.denonavr python39Packages.HAP-python

@jonringer jonringer merged commit 70e8dbc into NixOS:master Dec 30, 2020
@mweinelt mweinelt deleted the home-assistant branch December 30, 2020 20:15
@ol-iver
Copy link

ol-iver commented Jan 3, 2021

denonavr doesn't build with Python 3.9 but builds with older Pythons. Looks like an upstream issue, should we report it and disable the build of denonavr on Python 3.9 thinking ?

Thanks, reported in scarface-4711/denonavr#179.

Fixed, please use denonavr==0.9.10

@thiagokokada thiagokokada mentioned this pull request Jan 3, 2021
Merged
10 tasks
@thiagokokada
Copy link
Contributor

@scarface-4711 Thanks, I opened a PR: #108326

@mweinelt mweinelt mentioned this pull request Jan 6, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@colemickens colemickens Awaiting requested review from colemickens

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @thiagokokada @ol-iver @prusnak @jonringer