Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdm: 1.9.0.20170124 -> 2.0 #107945

Merged
merged 4 commits into from Dec 30, 2020
Merged

fdm: 1.9.0.20170124 -> 2.0 #107945

merged 4 commits into from Dec 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2020 •
edited by ghost

Motivation for this change

fdm 2.0 was released last year and our version was from 2017.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Added myself as maintainer as I am an active NixOS user and heavy fdm user (I receive notifications for changes in the upstream repository).

@ofborg ofborg bot requested a review from 7c6f434c December 30, 2020 07:15
@prusnak prusnak closed this Dec 30, 2020
@prusnak prusnak reopened this Dec 30, 2020
@prusnak
Copy link
Member

prusnak commented Dec 30, 2020 •
edited

The package uses some very old convention, we can now use more modern and concise way.

Rewrite this:

let

   baseName = "fdm";
   version = "2.0";

 in

stdenv.mkDerivation {
  name = "${baseName}-${version}";
  src = fetchFromGitHub {
    owner = "nicm";
    repo = baseName;
    rev = "370b04f165b0bb2989be378bb7e66b14f042d3f9";
    sha256 = "0j2n271ni5wslgjq1f4zgz1nsvqjf895dxy3ij5c904bbp8ckcwq";
  };

into this:

stdenv.mkDerivation rec {
  pname = "fdm";
  version = "2.0";

  src = fetchFromGitHub {
    owner = "nicm";
    repo = pname;
    rev = version;
    sha256 = "0j2n271ni5wslgjq1f4zgz1nsvqjf895dxy3ij5c904bbp8ckcwq";
  };

@ghost
Copy link
Author

ghost commented Dec 30, 2020

All right @prusnak, done. Do tell if you prefer the syntax modernisation to be merged into the version bump commit. My personal preference tends to be to keep everything minimal for clarity, but I am happy to comply with whatever is preferred by the project.

@prusnak prusnak merged commit 037e979 into NixOS:master Dec 30, 2020
@prusnak
Copy link
Member

prusnak commented Dec 30, 2020

Thanks, great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prusnak