Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitoxide: Fix build on darwin #107934

Merged
merged 1 commit into from Jan 1, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 30, 2020
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107934 run on x86_64-darwin 1

1 package built:
  • gitoxide

Copy link
Member

@syberant syberant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like prusnak said, using lib instead of stdenv.lib is a bit cleaner.
Though it doesn't matter as much in such a small derivation.

Otherwise, thanks a lot for fixing it on Darwin!

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107934 run on x86_64-darwin 1

1 package built:
  • gitoxide

@SuperSandro2000 SuperSandro2000 merged commit eef9046 into NixOS:master Jan 1, 2021
@SuperSandro2000 SuperSandro2000 deleted the gitoxide-darwin branch January 1, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants