nixos/nix-gc: add persistent and randomizeDelaySec options #107959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tex
changed the title
Mic92
changed the title
Mic92
reviewed
Dec 30, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
I decided to give a try and test the PR to make sure everything is alright. My {
# Backport module from unstable.
imports = [
/home/thiagoko/Projects/nixpkgs/nixos/modules/services/misc/nix-gc.nix
];
disabledModules = [ "services/misc/nix-gc.nix" ];
# Enable NixOS auto-upgrade.
system.autoUpgrade = {
enable = true;
dates = "daily";
};
}And this is the result: ❯ systemctl cat nix-gc.timer
# /nix/store/4y61sz2gg2h7cs1bky41qaphbz08q0z2-unit-nix-gc.timer/nix-gc.timer
[Unit]
[Timer]
OnCalendar=weekly
Persistent=true
RandomizedDelaySec=0
~
❯ systemctl cat nix-gc.service
# /nix/store/4fhwmqacnq0vgx6x55j95jlyp5lh1ip4-unit-nix-gc.service/nix-gc.service
[Unit]
Description=Nix Garbage Collector
[Service]
Environment="LOCALE_ARCHIVE=/nix/store/a2px4kdz1jm03f8ifr1pzir0csfmyrlv-glibc-locales-2.31/lib/locale/locale-archive"
Environment="PATH=/nix/store/z1qvlavy35wanw5k54fvvfffws5bvigj-coreutils-8.31/bin:/nix/store/3fvzxz59gacagpwyzpfdiinc1yv46hw1-findutils-4>
Environment="TZDIR=/nix/store/w1g27pgslf28nh1py1szj7lk4xksdhqq-tzdata-2020c/share/zoneinfo"
ExecStart=/nix/store/9gvh04r9wsw0hhi2l1r2vzfs9pvg9a4b-unit-script-nix-gc-start/bin/nix-gc-start So, 💯 . |
|
@tex Can you fix the merge conflict? |
thiagokokada
approved these changes
Jan 31, 2021
I don't know systemd that well. @Mic92 If you could take another look then I think it should be fine. |
Mic92
reviewed
Feb 7, 2021
Mic92
approved these changes
Feb 7, 2021
tomberek
force-pushed
the
nixos/nix-gc
branch
from
dfc820c
to
2df04c5
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am complaining about nix-gc not correctly working in laptop environment where laptop is turned on and off unpredictable causing those timers never expire and this service never executed.
Here is my fix.
I think that current situation is making this service unusable on laptops.
One can add this to his configuration.nix: systemd.timers.nix-gc.timerConfig.Persistent = true; but it is not apparent for users...
#15689
#75861
#107805
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)