Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akonadi: add missing kaccounts deps #107948

Merged
merged 4 commits into from Jan 3, 2021
Merged

akonadi: add missing kaccounts deps #107948

merged 4 commits into from Jan 3, 2021

Conversation

eliasp
Copy link
Member

@eliasp eliasp commented Dec 30, 2020

Motivation for this change

Enable the KAccounts Integration for Akonadi

Things done

As required by 757661745c55c9b5a667c596b989c1ac16101327 I pulled in ce16b0a9280, ab4bda4c456 and 8e4c0493ed5 from #98212 as per #98212 (comment)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eliasp eliasp requested a review from ttuegel as a code owner December 30, 2020 09:25
ttuegel
ttuegel reviewed Dec 30, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/kde/default.nix Show resolved Hide resolved
freezeboy and others added 4 commits December 30, 2020 23:20
@freezeboy @ttuegel @eliasp
accounts-qt: migrate to libsForQt5 derivations to fix cmake config
73779ab 
Co-authored-by: Thomas Tuegel <thomas.tuegel@runtimeverification.com>
@freezeboy @eliasp
kdeApplications.kaccounts-integration: init 20.08.2
0bc5689
@freezeboy @eliasp
signond: init 8.60
eb6bdaa
@eliasp
akonadi: add missing kaccounts deps
4a700a5 
To enable the KAccounts Integration for Akonadi, the following deps had
to be added:
- signond
- accounts-qt
- kaccounts-integration
@ofborg ofborg bot requested a review from ttuegel December 31, 2020 00:40
@ttuegel
Copy link
Member

ttuegel commented Dec 31, 2020

@GrahamcOfBorg build akonadi

@ttuegel ttuegel merged commit 73a76de into NixOS:master Jan 3, 2021
@ttuegel
Copy link
Member

ttuegel commented Jan 3, 2021

Thanks!

@lukegb
Copy link
Contributor

lukegb commented Jan 3, 2021

This appears to be failing ofborg evaluations (e.g. on #108338, with https://gist.github.com/GrahamcOfBorg/24554b14bfabb214714132657484e3b1)

@lukegb
Copy link
Contributor

lukegb commented Jan 3, 2021

Will be fixed by #108345.

@eliasp eliasp deleted the akonadi-kaccounts branch January 3, 2021 20:32
@eliasp eliasp mentioned this pull request Jan 3, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@freezeboy freezeboy Awaiting requested review from freezeboy

@rittelle rittelle Awaiting requested review from rittelle

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eliasp @ttuegel @lukegb @freezeboy