Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/scripts/update.nix: Do not traverse lists #107014

Merged
merged 1 commit into from Dec 16, 2020
Merged

maintainers/scripts/update.nix: Do not traverse lists #107014

merged 1 commit into from Dec 16, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 16, 2020

Motivation for this change

Lists items are not directly accessible like attributes in attrsets are. This makes it hard to represent their address in UPDATE_NIX_ATTR_PATH environment variable passed to update scripts.

Given that I only introduced list support for gnome3 attribute set and we stopped using them there, let’s remove the list support again. NixOS modules are better place for package collections anyway.

This was meant to go in with #98304 but got accidentally omitted somehow.

Fixes: #106935

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
maintainers/scripts/update.nix: Do not traverse lists
c485a93 
Lists items are not directly accessible like attributes in attrsets are.
This makes it hard to represent their address in `UPDATE_NIX_ATTR_PATH`
environment variable passed to update scripts.

Given that I only introduced list support for `gnome3` attribute set
and we stopped using them there, let’s remove the list support again.
NixOS modules are better place for package collections anyway.

This was meant to go in with NixOS#98304
but got accidentally omitted somehow.
@jtojnar jtojnar mentioned this pull request Dec 16, 2020
Closed
@jtojnar jtojnar merged commit 31ded18 into NixOS:master Dec 16, 2020
@jtojnar jtojnar deleted the update-script-no-lists branch December 16, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

automatically updating lxqt fails
2 participants
@jtojnar @romildo